feat: make check for updates menu item dynamic (!waiting for upstream!)#1124
Draft
nmggithub wants to merge 1 commit intopingdotgg:mainfrom
Draft
feat: make check for updates menu item dynamic (!waiting for upstream!)#1124nmggithub wants to merge 1 commit intopingdotgg:mainfrom
nmggithub wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR cannot be merged in its current state as it depends on features not in upstream Electron yet, but I hope for that to change in the near future. Refs: electron/electron#50266
Once Electron truly supports it, this will allow us to change the label of the "Checking for Updates..." menu item on the fly.
Why
This provides a much better user experience by giving visual indications of what is happening during the update process.
UI Changes
To be added later, when this actually works.
Checklist
Note
Make 'Check for Updates' menu item label and enabled state dynamic based on update status
checkForUpdatesMenuItemin main.ts reused across the macOS app menu and Help menu, replacing two separate inline definitions.updateStateListenersregistry sosetUpdateStatenotifies all listeners on every update, including one that updates the menu item's label and enabled state based on the current update status.setUpdateStatenow iterates over listeners rather than callingemitUpdateState()directly; both behaviors are preserved, but new listeners can now be registered without modifyingsetUpdateState.Macroscope summarized fd1c6ae.